chengjoey
chengjoey
This should be a feature rather than a bug because if a replacement value cannot be found and `allowUnresolved` is true, the template string will be used, which is as...
/assign we could use `scaleNamespacer.Scales(namespace).Get(context.TODO(), gvr.GroupResource(), name, metav1.GetOptions{})` get scale
/hold pkg/daemon/kuberuntime/kuberuntime_container.go:L99 HashWithoutResources broken by this [pr](https://github.com/kubernetes/kubernetes/pull/124220)
/hold cancel @ABNER-1 @LavenderQAQ PLAT It seems that I have broken the inplace updateResource logic, is there any background information I need to know?
@ABNER-1 Now all the CI have passed (except codecov), PTAL
hi @ABNER-1 @furykerry , thanks for reviewing I will make the requested changes, and then the community meeting is this Thursday evening, right? I will try to attend if I...
also fix flaky unit-test https://github.com/openkruise/kruise/blob/fc611f0505d14bfe049040de7e91d0c217be46bb/pkg/daemon/imagepuller/imagepuller_controller.go#L98-L102 @ABNER-1 there seems go is unnecessary, `workerLimitedPool.Start()` is enough, what do you think
> plz remove it. Thanks! done
> < Grpc-Metadata-Content-Type: application/grpc https://github.com/argoproj/argo-workflows/blob/ddbb3c7ad5b498d50514b3c1158ded56e333d75b/cmd/argo/commands/common/logs.go#L14-L35 `argo` use grpc client, this is the interface of grpc protocol argo-server seems compatible with both http and grpc, and `/api/v1/workflows/{namespace}` seems to work fine