chengjoey

Results 200 comments of chengjoey

I can't reproduce it either. I'm running on `v3.5.10`. This is the result of my run. I tried about 3 times and each time it was `Succeeded` ```yaml apiVersion: argoproj.io/v1alpha1...

https://github.com/argoproj/argo-workflows/blob/ddbb3c7ad5b498d50514b3c1158ded56e333d75b/workflow/controller/operator.go#L242-L250 hi @agilgur5 , artifacts gc will only be running when task reconciliation is completed. I think the pod has finished running at this time. and i think this is...

> > I'm pretty sure the ArtifactGC Pod _itself_ fails (due to the architecture) > > Hmm, no, ArtifactGC can run on `arm64`; your Pod that fails due to arch...

thanks for your patience @agilgur5 @juliev0 , In this PR I removed `anyPodSuccess`, `allArtifactsDeleted` is enough to ensure that artifacts can be GCed

> mostly consistency comments on the test below thanks @agilgur5 , all has done

https://github.com/argoproj/argo-workflows/blob/ddbb3c7ad5b498d50514b3c1158ded56e333d75b/docs/enhanced-depends-logic.md?plain=1#L70 see this description, continue.on is not available on dependencies

I can reproduce it in minikube, and it seems that this is not 100% reproducible. There is a certain probability that it can be forwarded to the new svc. I...

> > k8s.io/[email protected]/tools/cache/reflector.go:232 > > Perhaps this is due to [kubernetes/kubernetes#115658](https://github.com/kubernetes/kubernetes/issues/115658) ? no, because the nginx-controller log shows that the `delete` event is received.may be caused by the different order...