chengjoey
chengjoey
> @chengjoey the PR needs rebase against main branch. done
> @chengjoey it seems the CI failures are related with the PR changes. hi @aanm , Could you please help me figure out why ci failed? I'm not sure how...
> @chengjoey please try to rebase your PR against the main branch to see if the issue gets fixed. done
> @chengjoey it needs a rebase against main branch to solve the conflicts. done~
> Once the test failures have been resolved, please use the "Ready for Review" button at the bottom of the PR to bring it back to reviewers' attention. Thanks @joestringer...
> /test @joestringer ,please test again, because I re-pushed to resolve the conflict
> @chengjoey I was on break. Could you rebase to remove the merge commit? done
> @chengjoey not sure if you raced against some other PR going into `main` or what, but there are a few conflicts. Could you rebase once more against the tip...
> Hi @chengjoey, sorry looks like you've picked up conflicts again. Seems to be a busy area that you're touching :) done~