Caleb Cartwright
Caleb Cartwright
Have only done a quick pass through this but a couple early notes: - given the 10k ceiling, that seems like a case we should handle explicitly in our rendering,...
@sunny0826 just want to make sure you saw this :point_right: https://github.com/badges/shields/pull/8166#issuecomment-1175232531
> > @sunny0826 just want to make sure you saw this point_right [#8166 (comment)](https://github.com/badges/shields/pull/8166#issuecomment-1175232531) > > I saw this, but wasn't sure what I needed to do. Ah okay, no...
After looking through a little more closely, I see that you are already applying special case handling to the >10k scenario which is good :+1: (I was just emphasizing that...
Thanks for the suggestion! > You can already do it with GitHub, after all. Want to note that just because a badge exists for service Foo doesn't make a similar...
Thanks for sharing your idea and including relevant details! I've not read through the specifics of the documentation but sounds straightforward enough and beneficial. This should be a relatively easy...
> I would like to work on this issue. > > @calebcartwright - thanks for your comment, I will make sure that the ref parameter is accepted as a query...
Closed in fa3839cdab3a7fc7b15c1cd35b4da175d4e28b07
Shifting discussion over here vs. the PR for now. Could you please elaborate on the specific badges you are proposing, and do so individually? The motivation field in our issue...
I appreciate the extra information. It's somewhat helpful, though I still feel like you're more focused on the implementation details as opposed to the motivation. We don't typically add a...