Caleb Cartwright

Results 714 comments of Caleb Cartwright
trafficstars

> On this one, are you just talking about rounding, or are there other things here? If so, can you give an example. I'm not sure I'm with you on...

I'll also add that I'm just digging in on my belief that we need to agree to a model or procedure for how we want to handle this horizontal vs...

> Here is a starting point suggestion for a more concrete "rule" we could write down and apply here to express that concept: > > I guess another question here...

expanding on this, i think the "why" for standardizing precision and having horizontal consistency there is because a core part of our ethos is badges being clean, clear, & concise...

> Then we just kinda used it because it was already installed. Then we retrofitted "consistency" as a justification for not changing things later. I'm not sure it is a...

Just as a reference to another section of the guide that may be operative here: https://doc.rust-lang.org/nightly/style-guide/types.html#line-breaks

this was the sole topic we discussed in the t-style meeting today and it was one we discussed at length Given the pending deadlines for the 2024 Edition work, our...

i think we may need to gate this behind 27, as annoying as that would be. thoughts?

> Provide an option that makes such errors non-fatal (I though error_on_unformatted=false would, but it does not). FWIW we're planning on doing this for both error_on_line_overflow (https://github.com/rust-lang/rustfmt/issues/3391) and error_on_unformatted, just...

Excellent, thanks @puf17640! We've got a great [tutorial](https://github.com/badges/shields/blob/master/doc/TUTORIAL.md) that walks through the process of creating a new badge, and you can ping us here and/or on Discord with any questions