Caleb Cartwright

Results 707 comments of Caleb Cartwright
trafficstars

> It seems their way of working is that everything is an item that has different properties like score (upvotes), karma, descendants (comments), etc. Yes I realize that, and it's...

> > Have more narrowly scoped routes with error handling > > I think this is a good way. The code will be less complex, it has better SOC and...

> Do you mean to say that badge will have to know if the requested item is story/poll or anything? Shouldn't the user take care of that? > > I...

Also, will you have the bandwidth(and interest) over the next day or two to address https://github.com/badges/shields/pull/7463#issuecomment-1008032890? That's a separate issue which needs to be fixed ASAP and not coupled to,...

> Although I am stuck with my day job, I'll spare some time, to fix [this](https://github.com/badges/shields/pull/7463#issuecomment-1008032890). No worries, we know how that goes. Thanks for taking care of it :pray:

@abitrolly - Chris articulated quite clearly why this feature does not exist today, as well the things that would need to be discussed to determine if this is even a...

> Do you have any further thoughts beyond the points I've already listed Caleb? Bah sorry, I forgot to hit the comment button the other day. To the question asked,...

Oh and I guess another point I'll add is that there are some badges which do arguably have a natural link that could be included, but I've found I actually...

> It currently does not allow to select a specific check run (job) as envisioned in https://github.com/badges/shields/issues/4364 but this can certainly be added later (as query parameter). Interesting, thanks for...

> Should it be :ref+ or :ref*? That determination is driven off the requirements of the upstream endpoint. Most of the time the upstream endpoint supports an optional parameter that...