Caleb Cartwright

Results 710 comments of Caleb Cartwright
trafficstars

What I think I'd like to do is get this merged such that it's timed to land with the addition of the `style_edition` option so that we can have a...

Thanks! The most immediate need is really just an enumeration of the differences in one place, as succinctly as possible. Even something as simple as comments posted on this issue...

### Proper indention of single generic bound with multiline formatting **Reference in codebase**: [types::join_bounds_inner](https://github.com/rust-lang/rustfmt/blob/1d8491b120223272b13451fc81265aa64f7f4d5b/src/types.rs#L1065-L1075) ### V2 ```rust pub trait PrettyPrinter { // } pub trait PrettyPrinter + fmt::Write { //...

TODO: Ensure #4800 is covered somewhere in a human-readable manner

This is intriguing, and I suspect, may potentially address a bevy of other issues (at least partially). I'd like to see the idempotence check with this branch as well because...

Thanks for the report. In the more immediate term you may just want to change the call site delims to `{}` or `[]` to prevent this from occurring, or if...

thank you for this, happy to merge once conflicts are resolved

That's an interesting idea @Stargateur Formatting toml files is outside rustfmt's scope (at least currently), though I can see how having the optional/opt-in ability to format toml files would be...

> @calebcartwright want me to add entries for these PRs too? > > * [Format diff line to be easily clickable #5971](https://github.com/rust-lang/rustfmt/pull/5971) > > * [Fix for #3805 - wrap...

It looks like the [Style Guide actually already includes a spec for Cargo.toml](https://github.com/rust-dev-tools/fmt-rfcs/blob/master/guide/cargo.md), so IMO formatting Cargo.toml files accordingly is something that rustfmt should indeed support. There's a few things...