Caleb Cartwright

Results 714 comments of Caleb Cartwright
trafficstars

No worries @stjepangolemac fine to ask here (and probably worth having pointers to various issues anyway). In short, we're limited by the information that's actually available. More detailed in the...

I appreciate the interest and willingness of folks to participate in discussions, but should you choose to do so, a gentle reminder to be sure to thoroughly read the thread...

Seems I forgot to hit the "comment" button the other day, but yes @SimonSapin that type of grouping and variant should be possible with the information available to rustfmt. However,...

Minimizing prior comments that were generalized questions about stabilization. Please refer to content in the issue description, subsequent comments above, and the below Discussions with more details about stabilization https://github.com/rust-lang/rustfmt/discussions/5365...

fwiw I know this has been reported before, but can't find the prior issues atm

Thanks for reaching out @Ten0, could you expand a bit on your use case? IIUC, you've been inserting `@generated` comments within the first few lines at the top of generated...

Gotcha, thanks for confirming. We do need to get the default updated because we inverted the option itself to avoid double negatives but failed to make the corresponding update to...

> Is there a technical reason this is ignored for stdin? Yes, at least in so far as current state behavior. See #5172 and https://github.com/rust-lang/rustfmt/blob/a3b2bfc2db33ec3bed266404e6391c145e000df0/src/formatting.rs#L79-L81

> @calebcartwright is there an issue or something somewhere else that tracks the stdin support that I can upvote? It would be nice if format-on-save in VS Code would ignore...

Thanks for the PR! We've historically stayed away from any gated features (obviously excluding rustc_private which we need for consuming compiler internals). However, while I'm not sure I'm ready to...