Bartlomiej Plotka

Results 706 comments of Bartlomiej Plotka

Merged https://github.com/GoogleCloudPlatform/prometheus/pull/122 for now as this needs some love. The race is on test (using discoveryManager.targets without lock while .Run is till there), but I need to verify we won't...

Yea, sorry for not explaining why, I should have updated the description. Edited it in (:

Hello from the Bug Scrub! > I think ignoring newlines matches the expectation of most users of Prometheus. Sounds like [@gouthamve comment is still](https://github.com/prometheus/prometheus/issues/7859#issuecomment-683810012) relevant. Prometheus 3.0 coordinators, was this...

Yea, to be very blunt, I don't see how we can maintain/change code for highly used component with tests that disable important logic majority of callers has to use 🙈...

Hello from the Bug Scrub! There is no recent activity here, still to do, the last PR was abandoned. Still it looks like something to be done, and it's not...

Yup, explicit field in config might be more reasonable. But otherwise, interesting extension. It makes Prometheus even more fanout capable, like Thanos Querier is.

Also client_golang supports headers, but with extra tripperware

Happy to configure different optimizers in future. But it should case driven. I can't see anything "too aggressive" so far 🤔

No big diffs in Mem, CPU and latencies: ![image](https://github.com/prometheus/prometheus/assets/6950331/b6a95eba-ed83-4061-b1f7-ebd1141cf7c2) ![image](https://github.com/prometheus/prometheus/assets/6950331/59da6efb-6d09-459d-b81c-80595a790d18) ![image](https://github.com/prometheus/prometheus/assets/6950331/59fc0eec-56b9-4174-9991-2238fe40f209)