Bartlomiej Plotka

Results 704 comments of Bartlomiej Plotka

Starting formal design doc, feel free to collaborate (: https://docs.google.com/document/d/1ajMPwVJYnedvQ1uJNW2GDBY6Q91rKAw3kgA5fykIRrg/edit#

BTW we are moving with this work item finally 🤗 I made a quick PoC here:https://github.com/thanos-io/thanos/pull/4901 The first iteration is done by @fpetkovski https://github.com/thanos-io/thanos/pull/4917 We can work on first iteration,...

Found workaround: ``` func BenchmarkGoroutines(b *testing.B) { defer goleak.VerifyNone( b, goleak.IgnoreTopFunction("testing.(*B).run1"), goleak.IgnoreTopFunction("testing.(*B).doBench"), ) b.ResetTimer() for i := 0; i < b.N; i++ { wg := sync.WaitGroup{} wg.Add(2) go func() {...

Hey, I looked, and this is not desired functionality, I am afraid. ): Explained in https://github.com/prometheus/client_golang/issues/1137 Hope that makes sense. I will close this PR to avoid confusion but feel...

Good question. I would say *labels have to be sorted*. From client_golang perspective, we have label sorting **enforced** by default. We are also experimenting with different label sorting flows for...

Sorry for lag and thanks @YaoZengzeng Yes that makes sense to me :+1: I think step 2 would be the most work, especially packing SAMPLED method to `SeriesSet`, but I...

Sorry for massive lag, proposed solution (: Also reach me on IRC bwplotka or [CNCF slack channel](https://slack.cncf.io/) -> `bwplotka` if you need to ping me - bit spammed on email.

Hi @YaoZengzeng this would be nice to have (: Any progress? What are the blockers? :hugs:

@Sudhar287 any update maybe? (: We kind of slowly need that for various tooling. (: If not I think it might be good Community Bridge issue. cc @khyatisoneji

Wow, I think there is misunderstanding, I don't think anything is blocked and we can start working on it right way.