bruvzg

Results 289 comments of bruvzg

> I guess you'll add similar ones for undo/can_undo/undo_action_description etc? Done. Currently, it's not fully integrated with the editor, "Edit" menu items work in editor (as generic content independent Undo/Redo),...

> should these not be callbacks returning strings to be called on menu validation (before menu is opened) just like can_undo and can_redo to ensure they're updated at the correct...

Changed `can_*` properties to `bool`. Both can be set from `popup_open_callback`. In this case, callback seems like overkill.

Pressing "Cancel" emit `canceled` signal not `*_selected`.

Maybe custom template in the export preset is not set correctly, it should point to the export template executable, and make sure it is set for both release and debug....

Are you cross-building or building on a ARM64 device? I would suggest using official build containers - https://github.com/godotengine/build-containers/, since a lot can go wrong when setting up cross-compiler manually.

Containers are used with these build scrips https://github.com/godotengine/godot-build-scripts, you can pass `-c` to the `build.sh` skip checkout, and it should build source in the current folder, or modify it to...

> Cannot change mode to rwxr-xr-x: Operation not permitted Sorry, completely forgot about this. This issue was reported few times before, and seems to be specific to Ubuntu, not sure...

Code seems fine, will fully check it tomorrow.