Ben Thomson
Ben Thomson
Just to note, we can run database tests in Storm. There's a couple of them in there now - https://github.com/wintercms/storm/tree/develop/tests/Database/Traits. They just need to extend the `DbTestCase` base test class.
Just to note - this PR could be implemented via https://github.com/wintercms/storm/pull/134 instead if we wanted to go down that route. @mjauvin's use case could be simply extending a particular instance...
Thanks for letting us know @ArturCiolkiewicz - could you post that as a separate issue for us? I'll be able to sort it out within a couple of days.
@mjauvin if you could add type hints to those methods - ie. `(string $name, array $config)` - I'm happy for you to merge.
Closed in favour of #111.
@LukeTowers not quite sure what's happening there - the Backend module classes are using Composer's PSR-4 autloading, so I don't think it would have anything to do with the class...
Seems like a deprecation error to me. For the moment, while we work to put out a fix for that issue, you may need to change your error reporting level...
@m-paniez9292 thanks for confirming. The underlying issue has been fixed by https://github.com/wintercms/winter/pull/1031 - we just need to release a new version with this fix.
@Mrkbingham thanks for submitting this PR. We still provide the `pretend()` method in our [Mailer implementation](https://github.com/wintercms/storm/blob/develop/src/Mail/Mailer.php#L511-L526) for backwards compatibility, and it does serve a separate purpose to the fake Mail...
@LukeTowers I was going to fix the validation and collection ones at the same time, the problem though was that anchoring the rules/commands in those pages results in every validation...