storm
storm copied to clipboard
Add withoutChildren scope to NestedTree
Currently building a Winter.User blogs plugin, based on Winter.Blog.
I needed to list all the available parent categories for the current one, but excluding the current category's children to avoid circular references.
I thought it would be good to add this scope to the core.
@RomainMazB can you add a unit test for this?
All the actual tests are included in wintercms/winter, is there where you want me to add it?
As a side note, it could be more clear to pull back almost all of this wintercms/winter test folder inside winter/storm as most of the tests are more related to storm than winter IMO
@RomainMazB
As a side note, it could be more clear to pull back almost all of this wintercms/winter test folder inside winter/storm as most of the tests are more related to storm than winter IMO
I agree with this. It's something on my list to do, but the list is loooooooong, so won't be any time soon.
This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days. If this is still being worked on, please respond and we will re-open this pull request. If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.
@RomainMazB the tests have been reorganized in the Winter core now, are you able to add a test case for this? Ideally at some point we should probably be able to run database tests on this library directly but for now a PR to the wintercms/winter with the test case for this addition and perhaps an addition to the docs and we should be able to merge this.
Just to note, we can run database tests in Storm. There's a couple of them in there now - https://github.com/wintercms/storm/tree/develop/tests/Database/Traits. They just need to extend the DbTestCase base test class.
This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days. If this is still being worked on, please respond and we will re-open this pull request. If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.
@RomainMazB are you still interested in getting this merged?
This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days. If this is still being worked on, please respond and we will re-open this pull request. If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.