wn-builder-plugin icon indicating copy to clipboard operation
wn-builder-plugin copied to clipboard

Published 20 hours ago • verified publisher icon wintercms

localization of error messages

Open WebVPF opened this issue 3 years ago • 6 comments

WebVPF avatar Jan 15 '22 11:01 WebVPF

Please also review all of the changed files to ensure that the Lang facade is imported correctly for each one.

@LukeTowers done

WebVPF avatar Jan 15 '22 19:01 WebVPF

@WebVPF @LukeTowers this appears to break the unit tests since they are doing string comparisons on some exceptions.

Also, I believe our standard is to not translate system exceptions.

bennothommo avatar Jan 16 '22 02:01 bennothommo

At least some of these are application exceptions though and are triggered by the user entering data which probably should be translated. System exceptions designed to be searched online shouldn't be translated but exceptions that are meant to inform the user how to solve their problem with the message itself can be translated.

LukeTowers avatar Jan 16 '22 02:01 LukeTowers

@LukeTowers I removed the translation of system exceptions.

WebVPF avatar Nov 30 '22 09:11 WebVPF

@bennothommo tests are failing, is that because of the classloader changes?

LukeTowers avatar Dec 01 '22 01:12 LukeTowers

@LukeTowers not quite sure what's happening there - the Backend module classes are using Composer's PSR-4 autloading, so I don't think it would have anything to do with the class loader changes. I also just did a simulation of the same thing the tests do, and the tests ran fine for me.

bennothommo avatar Dec 01 '22 01:12 bennothommo