Ava Hahn

Results 20 comments of Ava Hahn

I like the warnings about the performance limitations (until we fix them at least) but as a potential user I am not sure what I am being warned from in...

Deprecation notice on unit-wasm: https://github.com/nginx/unit-wasm/pull/28

> Make running Unit as an unprivileged user easier (automatic --flag overrides for .pid, .log, and .sock files) We dont have to modify Unit if we suggest using the Docker...

I am a huge fan of having GH releases that offer a static compiled binary. I think if we can settle on a path forward for our CLI we can...

>Current friction points when running Unit inside of Docker: Control socket requires running curl inside the container (or restarting the container to pick up modified config file) unitc handles this...

> Feel free to give me your `Reviewed-by:` like [here](https://github.com/nginx/unit/pull/1166#issuecomment-1981582764) (only seeing as there's a single commit you don't need to mention which commit ;)) ```Reviewed-by: Ava Hahn ```

Here's a patch that fixes the formatting nits: ```diff diff --git a/src/nxt_h1proto.c b/src/nxt_h1proto.c index 6550efb9..16f6dcaa 100644 --- a/src/nxt_h1proto.c +++ b/src/nxt_h1proto.c @@ -893,10 +893,8 @@ nxt_h1p_request_body_read(nxt_task_t *task, nxt_http_request_t *r) nxt_buf_t *out...

> Or was it just a tag you created so there was a tag associated with the release? It was made automatically by the release action it seems > Perhaps...

@ac000 @callahad What is the path forward for this changeset?