Jacob Wujciak-Jens

Results 248 comments of Jacob Wujciak-Jens
trafficstars

> If you're concerned about resource/machine usage, we can build a limited set of cuda versions (what's the one(s) you'd like to focus on?) and build the larger set on...

@luhenry looks good but could you change the test skipping code so it doesn't cause gtest to pick up a [failed test](https://github.com/facebookincubator/velox/actions/runs/8627576322/job/23662809679?pr=9335#step:11:684)? Otherwise this will always fail the adapters job...

> It should be adding ~217MB I did local testing (with both versions though) and that added ~ 800mb to the final image but in any case it's fine as...

@luhenry yeah the fix is in #9451 feel free to apply it to this PR, I hope it get's merged soon^^

Ah sorry, I missed that it uses stuff from scripts.

I think your solution is great and working on a project with 4k open issues has lead me to have a much easier time closing issues :D

> it works well, I compiled it successfully on my home MacBook. If you still have an issue please open a new issue with the new problem :)

Closed as stale. Feel free to reopen if the same error persists or open a new issue if there are additional issues.

@CodingCat @Yuhta This is not exactly an issue related to velox but rather with your build environment, which makes it hard to reproduce (especially as I don't have a mac...

@darrenfu it seems like `immintrin.h` is included unguarded here: https://github.com/facebookincubator/velox/blob/main/velox/dwio/common/tests/Lemire/bmipacking32.h#L33 But that was last changed two month's ago and I doubt that this went undetected for so long so :shrug: