Asaf Mesika

I started writing a few comments then I realized I have some profound suggestions I thought maybe it's a better idea to raise them first. I think currently this PR...

> Hi @asafm > > > As I understand, this only happens once per instance of MLTransactionLogImpl. So I don't understand why you want to pass metric by metric. Something...

@tjiuming @poorbarcode I actually found this pattern already in Pulsar. See `ComponentStatsManager`

> @tjiuming @poorbarcode I actually found this pattern already in Pulsar. See `ComponentStatsManager` Why - this was only given as an example. Not relevant now since you already modified the...

@ChrisChinchilla

@ChrisChinchilla

Thanks for responding @wesleyk . In the following comments I'll list the positions I wish logging level to change: https://github.com/m3db/m3/blob/82b342908e4cf3a280e9898457381e1cfdc7634d/src/query/api/v1/handler/prom/read.go#L122-L129 Example error: ``` "msg":"error creating query","error":"1:54: parse error: missing unit...

https://github.com/m3db/m3/blob/82b342908e4cf3a280e9898457381e1cfdc7634d/src/query/api/v1/handler/prometheus/native/read.go#L136-L150 Example error: ``` "msg":"m3 query error","error":"promql.Walk: unhandled node type *parser.SubqueryExpr, avg(net_bytes_recv{host=~\"vkapp1\",interface=~\"(all|eth0|eth1)\"})[5m:10s]" ``` Here I think we can just straight out change log level to debug, since there might be...

https://github.com/m3db/m3/blob/82b342908e4cf3a280e9898457381e1cfdc7634d/src/query/api/v1/handler/prometheus/native/read.go#L213-L219 Example error: ``` "msg":"failed to render results","trace_id":"1bb297dd289e23c8","span_id":"1bb297dd289e23c8","rqID":"857da2be-ee0a-4dea-a46e-1f45c4317294","error":"write tcp 10.9.70.214:7201->10.9.25.73:46908: write: connection reset by peer" ``` Here it depends on the error. The error I've seen for example, which shouldn't...

@wesleyk