Documentation Error for Commit Log integrity error

[asafm]

trafficstars

The documentation at https://m3db.io/docs/m3db/architecture/commitlogs/ says :

Here are two integrity levels available for commit logs:

Synchronous: write operations must wait until it has finished writing an entry in the commit log to complete. Behind: write operations must finish enqueueing an entry to the commit log write queue to complete.

Depending on the data loss requirements users can choose either integrity level.

I was following the configuration code for commitlog.Options for Strategy and it seems that in server.go it is hard coded to be Behind integrity level:

	opts = opts.SetCommitLogOptions(opts.CommitLogOptions().
		SetInstrumentOptions(opts.InstrumentOptions()).
		SetFilesystemOptions(fsopts).
		SetStrategy(commitlog.StrategyWriteBehind).
		SetFlushSize(cfgCommitLog.FlushMaxBytes).
		SetFlushInterval(cfgCommitLog.FlushEvery).
		SetBacklogQueueSize(commitLogQueueSize).
		SetBacklogQueueChannelSize(commitLogQueueChannelSize))

Am I missing something in the code or it’s configured somewhere else?

[asafm]

@ChrisChinchilla

[gibbscullen]

@ChrisChinchilla

[asafm]

@ChrisChinchilla

[ChrisChinchilla]

Hey all, yes I saw the assignment, I am getting there, but this would involve me getting engineer time, which take a little longer…

[gibbscullen]

Following up on this; for this, we are going to update the documentation to make it more clear as the code in the config is correct.

[gibbscullen]

@ChrisChinchilla

[mhoffm-aiven]

Hey all,

Is it on the roadmap to make this parameter configurable? I would like to try synchronous writes.

Thanks