Asaf Mesika
Asaf Mesika
@tjiuming Maybe you meant @marksilcox ? I have a note regarding the way we write `NamespaceStatsAggregator`. The whole idea in the way the metric system is built today in Pulsar...
NamespaceStats and TopicStat do share metrics as they use the same metrics but aggregate to different level. One is raw, at topic level, and the other is simple aggregation to...
I definitely agree that for the developer you'll be spending more time writing this and checking for collisions, and maybe printing from one class one variable and then another class...
> The problem we have is that we need to collect by metric name, and not by topic/namespace as is currently happening. So for a metric such as `pulsar_rate_in` whether...
@merlimat Sorry to nag again - could you please take a look at the comments I mentioned you at? I want to be certain here.
All looks good on my end :) I'll try to find someone with write permission to wrap this up
@eolivelli Do you want to re-review your requested changes?
@marksilcox I'm compiling a document detailing exactly how the metric system works today in Pulsar, and while doing so I've come to understand how Pulsar Function metrics work. The bad...
@marksilcox Your work was great. We can settle for opening an issue and linking this PR to it - what do you say?
Just need to see how to get those tests green. @nlu90 How can we move forward?