Anjan Nath

> > [temp: replace code-ready/machine with anjannath/machine](https://github.com/code-ready/crc/pull/3308/commits/9ea4955b555010fd8f00b1be7925ce4cafb3e402) > > why? we need to modify the `SharedDir` struct, the PR: https://github.com/code-ready/machine/pull/66 on `machine` repo needs to be merged and then we...

@cfergeau @gbraad All the review comments are addressed and changes have been made PTALA, thanks!!

PR rebased on top of #3333

/retest

> Approved for podman bundle Unable to test for the OpenShift bundle > tested with the new `4.11.7` openshift bundle and working as expected

> Adding a second implementation of the `Config` interface to handle secrets is an interesting approach! One thing to have in mind though is that this 'secret' keyring will not...

> > ahh, didn't know, i don't think i ever tried this, but always assumed the cli `secret-tool` works via ssh > > My observations are only based on the...

@cfergeau i've tried to add a check to see if the keyring is accessible at the beginning when the secret store is initialised and not error out and crash the...

> you can not use a single option for a share. each share can have it's own set of variables. > > `host path`, `mount path`, `type`, `options`/`password` > for...

right, only considering the local use case for now, for a remote like scenario `sshfs` would be better