Add storage backend for configs based on OS provided secret store

[anjannath]

trafficstars

Fixes #3312

[anjannath]

Adding a second implementation of the Config interface to handle secrets is an interesting approach! One thing to have in mind though is that this 'secret' keyring will not always be available, I don't have access to gnome-keyring when I ssh into a linux box (but maybe this is a matter of configuration?)

ahh, didn't know, i don't think i ever tried this, but always assumed the cli secret-tool works via ssh

[cfergeau]

ahh, didn't know, i don't think i ever tried this, but always assumed the cli secret-tool works via ssh

My observations are only based on the pull secret keyring code, it always outputs a warning on my test machine, I never checked if it can be fixed.

[anjannath]

ahh, didn't know, i don't think i ever tried this, but always assumed the cli secret-tool works via ssh

My observations are only based on the pull secret keyring code, it always outputs a warning on my test machine, I never checked if it can be fixed.

seems like the issue is with dbus not being accessible/available, its failing in CI for ubuntu :(

[anjannath]

@cfergeau i've tried to add a check to see if the keyring is accessible at the beginning when the secret store is initialised and not error out and crash the whole thing when we try to access a secret config store that doesn't have access to the keychain, PTALA :)

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [cfergeau]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment