Akash

Results 101 comments of Akash
trafficstars

@kanishk98 is this ready to review or still WIP?

@kanishk98 are we planning to work on this after BrowserView PR gets merge?

@punchagan thanks for working on this. The feature looks good to me. @timabbott, @rishig thoughts? ![image](https://user-images.githubusercontent.com/2263909/51464982-d8b6db00-1d8c-11e9-8807-c2c2bfca7dab.png)

Here is the relevant code - https://github.com/zulip/zulip-electron/blob/7314c1f1dd0f34136277939560b031452d33ad35/app/renderer/js/main.js#L487

> instead of updating the menu for every new message. Do you have any thoughts/ideas/experience on this? Yeah, this is what I was thinking. Re-creating the tray on every new...

> I tried playing with this a little, but seems like 'click' doesn't get fired on Gnome Shell in Ubuntu? The context menu appears, but the click handler is not...

Looks good to me I'm just worried about [this](https://github.com/zulip/zulip-electron/pull/632#issuecomment-457482904). @abhigyank can you look into the performance part? In the worst case, I think we could go with the following approach...

>I think the click thing could be very shell or OS dependent, i.e. could be broken for some people (is the UX worth the broken risk? ). I think we...

@rishig anything else we should be doing here functionality wise?

@kanishk98 any update on this? https://github.com/zulip/zulip/pull/12677 should be helpful I guess. @rishig would it make sense to add an option like the following to mute an org in the desktop...