Andrew Guibert

I wanted to keep the `io.vertx.db2client.impl.drda` free of any Vertx dependencies, so that I could eventually split it out to write other DB2 clients with that code in the future...

Hi @michael-schnell, thanks for the suggestion. Before we go too far into compatibility and whether or not to use a default method, I wanted to question the value this new...

FYI this was implemented in Yasson API in this PR: https://github.com/eclipse-ee4j/yasson/pull/262/files The new API methods look like.... ```java public interface YassonJsonb extends javax.json.bind.Jsonb { /** * Reads a {@link JsonStructure}...

IIRC we only did `JsonStructure` and `JsonArray` because the other sub-interfaces of `JsonValue` that did not fall under structure/array (`JsonNumber` and `JsonString`) are already better represented as primitives or using...

Assuming Sebastian meant `PropertyVisibilityStrategy` with his suggestions instead of `PropertyNamingStrategy`, I think the following would be OK to add: - PropertyVisibilityStrategy.PUBLIC_PROPERTY: Use public getters / setters, or public fields (if...

true, if the app's module-info opens the package containing the JSON-B models then it will work OK, and if a user has their app modularized they should be familiar with...

I don't think any mapping to JSON-P types would be necessary here. JSON-B implementations are already capable of parsing out the JSON properties from a POJO class, so it should...

JSON-B uses JSON-P under the covers yes, but I'm thinking the equality checks can be made before we get down to the JSON-P layer. You are right that the internal...

When you say "order is important for equals", are you saying it is important for equality with JSON data, POJO equality, or both? Since the proposed method only deals with...

> Yes, im happy to get an equals in jsonp Yep, I think we could use something at the JSON-P level too. > If you want, Jsonb.equals(jsonValue, pojo) can make...