Andrew Guibert

Results 151 comments of Andrew Guibert
trafficstars

hi @scottkurz, I'm not quite clear on what you're referring to as an "application from some other package"? Do you mean that you have a resource class like `com.foo.StarterResource` and...

Ok, I understand the scenario now thanks. A few questions now: 1. What packages were being used in your case? 2. Did you get a clear error message when this...

I assume you are using the default `new MicroProfileApplication()` constructor here? If so, this should resolve using `new ImageFromDockerfile(String dockerImage)`, which does delegate to `ImageFromDockerfile(String dockerImageName, boolean deleteOnExit)` with `deleteOnExit=true`....

Should be fixed by https://github.com/testcontainers/testcontainers-java/pull/1745

No special steps or env to reproduce this bug -- it should happen all the time for `libertyRun`. I agree that this is more of a gradle problem, but in...

I think `name` is a bit too ambiguous -- I think people will confuse it with the DB name (`.setDatabase(String databaseName)` I chose `kind` because that is also what Quarkus...

So @vietj you are suggesting `setRDBMS(String)`? To me that doesn't imply that we are just setting the type name of the DB. Also, I'd like to keep longer acronyms out...

To me `setDBMS` still seems ambiguious. I would almost expect it to accept a composite object that represents the entire backend DB, not just the type of DB. How about...

Sure, I like `setDriverName(String)`. BTW, the reason I am trying to add this in the first place is so that a user can optionally specify the database type for situations...

Ok, sounds like we all agree on `driverName` 👍 As for where to specify it, `SqlConnectOptions` currently describe how to connect to the DB, but I don't think it would...