aemada-aws

Results 7 comments of aemada-aws

feat(synthetics): syn-nodejs-puppeteer-10.0 as supported runtime

Hi @pv-rudger. Thank you for the contribution. The PR looks good to go but PR build is failing because a snapshot is failing, do you have time to update it?...

(route53): RecordSetName incorrectly assumes zone name doesn't end with period when hostedzone.zonename is token

Closing in favor of https://github.com/aws/aws-cdk/issues/26572 which has a draft PR (https://github.com/aws/aws-cdk/pull/26597)

nested modules issue

Fixed in https://github.com/cdklabs/construct-hub-webapp/pull/1877

fix(opensearchservice): create `AWS::Logs::ResourcePolicy` instead of `Custom::CloudwatchLogResourcePolicy`

LGTM, but pr build is failing

fix(opensearchservice): create `AWS::Logs::ResourcePolicy` instead of `Custom::CloudwatchLogResourcePolicy`

Hi, sorry this was lost in my notifications. Could you please fix the conflicts and I will have a look? Thanks

fix(eks-v2-alpha): make `objectName` optional in `KubernetesObjectValue`

> Exemption Request > > Unit tests exist It still needs an integ test because building an invalid command would cause deployment to fail, which the integ test catches but...

fix(eks-v2-alpha): make `objectName` optional in `KubernetesObjectValue`

we should make this pr a `feat` not a `fix` because technically we are not fixing a bug but rather allowing extra functionality.