aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

fix(opensearchservice): create `AWS::Logs::ResourcePolicy` instead of `Custom::CloudwatchLogResourcePolicy`

Open wafuwafu13 opened this issue 6 months ago • 2 comments

Issue

Related https://github.com/aws/aws-cdk/issues/5343

Reason for this change

We don't need to create a custom resource to set the log group resource policy since it is supported by CDK and cfn.

https://github.com/aws/aws-cdk/blob/54e822284df3ae24dd00c30a84be0cf90bfda408/packages/aws-cdk-lib/aws-opensearchservice/lib/domain.ts#L1880-L1886

Description of changes

Use new logs.ResourcePolicy instead of new LogGroupResourcePolicy.

Describe any new or updated permissions being added

None

Description of how you validated changes

Pass unit/integ tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

wafuwafu13 avatar May 26 '25 20:05 wafuwafu13

Exemption Request

integration test is updated

wafuwafu13 avatar May 26 '25 20:05 wafuwafu13

memo: example of feature flag https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/cx-api/FEATURE_FLAGS.md#aws-cdkaws-route53-targetsuserpooldomainnamemethodwithoutcustomresource

wafuwafu13 avatar Jun 25 '25 13:06 wafuwafu13

:arrow_right: PR build request submitted to test-main-pipeline :arrow_left:

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

aws-cdk-automation avatar Jul 07 '25 08:07 aws-cdk-automation

LGTM, but pr build is failing

aemada-aws avatar Jul 07 '25 08:07 aemada-aws

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Jul 10 '25 09:07 mergify[bot]

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #34558 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 2 of 2 required status checks are expected.).

You can check the last failing draft PR here: #34940.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you do update this pull request, it will automatically be requeued once the queue conditions match again. If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify[bot] avatar Jul 10 '25 10:07 mergify[bot]

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1da83bf7f32ab8d9ee46229a3b51afe9ac4610c7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Jul 11 '25 14:07 aws-cdk-automation

Hi, sorry this was lost in my notifications. Could you please fix the conflicts and I will have a look? Thanks

aemada-aws avatar Oct 10 '25 15:10 aemada-aws