Adithya Kumar
Adithya Kumar
@snowleopard Yes. I'll address #232 and this as soon as possible. I need to write the tests and improve the docs in this PR I believe.
@Avasil Of Course :-). Some tasks that I find incomplete are written as `TODO`'s in `AdjacencyMap.hs`. We need to write tests for the module as well. Please ignore the `TODO`...
> Should I add things to your PR or wait after it's merged? Without adding the function `consistent` and tests, the PR probably should not be merged. > I will...
@jitwit I agree, this is not completely Dijkstra. But for an acyclic graph one does not need to maintain a set of nodes. One can directly relax the edges in...
> @adithyaov A general comment: it looks to me that there is a more general function that can be factored out of your implementation. Something fold-like, but for an acyclic...
@snowleopard I plan to address most of the TODOs before the merge. I apologize for the delay. Will address the CI fail as soon as possible.
@snowleopard That is an interesting failure. I think it's because I changed the arbitrary instance. Edit: Ah I see, It was because of how `comm` was defined. In the tests...
Please don't review this PR yet, I'll include a small writeup with all the major changes in this PR. This would make reviewing easier. I'll probably squash a few commits...
> I get "Sorry, This video does not exist." when trying to view that video. @noughtmare That is weird. I am able to watch the video. I wonder if the...
> I was wondering if I'm overlooking something: is the operation of an edge for a Labelled Graph ever used? @jmatsushita Could you please elaborate on this statement. `` is...