Adithya Kumar

Results 131 comments of Adithya Kumar
trafficstars

We can keep this open as there is more discussion on this. Pushing this to `0.10.0`

@harendra-kumar Can you elaborate on > Move the short definitions after the description of the combinator in haddocks.

Put the description first and the short definition later. The short definition is the implementation itself.

Verified in https://github.com/composewell/streamly/pull/1781

The test that you mention is in https://github.com/composewell/streamly/blob/master/test/Streamly/Test/Data/Array/Stream/Foreign.hs We need to discuss and add some good benchmarks. I'm pushing this to the next milestone as there are other important tasks...

I don't like the idea of hiding modules. Everything should be provided for use. We can however somehow differentiate between internal stuff that can be used (unstable). Having 3 namespaces...

Pushing this to the next milestone. See - https://app.circleci.com/pipelines/github/composewell/unicode-data/3/workflows/91ba2721-e8cb-4421-949f-22ceea47dfae/jobs/12 - https://github.com/composewell/unicode-data/tree/arm-ci - https://github.com/composewell/unicode-data/blob/arm-ci/.circleci/config.yml

For me, `...While` resonates with combinators that have the signature, `(a -> Bool)` whereas `...By` resonates with `(a -> a -> Bool)`. Although this isn't strictly followed in the library...

All the combinators will be reimplemented in serial stream. This can be corrected in serial stream. See https://github.com/composewell/streamly/issues/156

An idiomatic implementation of `groupsBy` would be to use `Parser.groupBy` with `parseMany`, ``` groupsBy = parseMany Parser.groupBy ``` The argument order in `Parser.groupBy` is similar to that of `Data.List`. Ideally...