Adam Viktora

Results 10 comments of Adam Viktora
trafficstars

I replaced the `isLabelBeforeButton` prop in Checkbox/Radio based on Katie's and Eric's suggestions with `labelPosition?: 'start' | 'end'` Codemod issue followup: https://github.com/patternfly/pf-codemods/issues/583

Can I get this issue assigned? Or is this issue already solved? (as mentioned in https://github.com/patternfly/patternfly-react/issues/7227) If I understand correctly, we want to replace the current React demo (https://www.patternfly.org/v4/components/data-list/react-demos#expandable-control-in-toolbar) with...

@hstastna Hello, you can use `isAriaDisabled` prop on the `SelectOption`. This way you will achieve the disabled styling, the option won't be selectable and the Tooltip can be attached. (Also...

@hstastna No problem. Sure, we can add the `isAriaDisabled` option directly to the Select documentation. Btw I think you are using an old URL. The Select component is now under...

You can close it. I opened a React followup to add a better example.

Yeah, the example is missing in the preview for some reason. In all the new branches I base on current `main` I see this compilation warning related to the new...

The example error in the surge build is probably because the surge build is old (I then force pushed another commit), and I was using a generic component in the...

This behavior was fixed in one of the latest PRs: https://github.com/patternfly/patternfly-react/pull/10207/files by adding the `shouldFocusFirstItemOnOpen` prop and setting it to false in all typeahead select examples. I believe it was...

Following on what Sarah has written about React tokens - we just discussed that on a working session, and it would be great to add some notes like this: -...

@kmcfaul It can be a follow up for sure