patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Published 20 hours ago • verified publisher icon patternfly

docs(Page): add example showing different type prop variants

Open adamviktora opened this issue 1 year ago • 2 comments
trafficstars

What: Closes #9868

Additional issues:

  • Section with type="subnav" for horizontal subnav navigation has dark text on a dark background. The Core example overrides the color with this class: Screenshot 2024-05-10 at 12 25 44 Should we do something similar in React? In V6 it will look fine, but not in V5.
  • Section with type="nav" for tertiary navigation: the tertiary navigation was removed in V6, we should rename it in the upcoming React example for V6 and the Core V6 example too - but what is the type="nav" used for in V6 if not tertiary navigation?

adamviktora avatar May 10 '24 10:05 adamviktora

Preview: https://patternfly-react-pr-10352.surge.sh

A11y report: https://patternfly-react-pr-10352-a11y.surge.sh

patternfly-build avatar May 10 '24 10:05 patternfly-build

Yeah, the example is missing in the preview for some reason. In all the new branches I base on current main I see this compilation warning related to the new Dropdown template:

Screenshot 2024-05-14 at 8 56 28

I don't know if it is related to why the example is not showing in the preview though.

About the -group section, as you say, it is not a type prop option of the PageSection, but a PageGroup component, and there is an example already for that. So I did not include the PageGroup there on purpose.

adamviktora avatar May 14 '24 07:05 adamviktora

#10416 should fix this problem, let's do a rebase of this PR to see if it resolves the issue.

jonkoops avatar May 22 '24 17:05 jonkoops