Adam Greig

We discussed this in today's meeting and the plan is: * Add a new atomic-device feature, default off * Only enable AtomicDevice when either the atomic-device feature is enabled or...

Thanks for the PR! We had a brief discussion about it in the weekly meeting today. Having the trait in the `asynch` module is fine. I think the only remaining...

Thanks for the prompt and the update. I'll add this to the agenda for discussion in the weekly meeting this Tues.

I think keeping them in the stm32h7 crate is probably best, we also kept the stm32l4+ in the l4 crate and I think it's a similar distinction. It doesn't really...

Yep, for security reasons it can only run on the SVD files already present in the repository. Do you think this is otherwise ready for review? Have you been able...

Thanks, looks good. The only thing I wanted to double check is deriving all the GPIOs from GPIOA. Typically GPIOA (and B) have a different reset value for MODER, OSPEEDR,...

We discussed this RFC in today's meeting. ### On alternatives: > We could simplify the implementation and API by only supporting Galois or only Fibonacci implementations, with the downside of...

I've updated with the feedback from the review meeting, with one variation: > Some applications may want to use the state as the multi-bit output, but it's awkward to have...

Sorry for the lack of response, I'm on holiday at the moment but I'll be back from Tuesday so can sort things out then.

It's hard to be sure without some more details about your application, but typically I would expect that other error coding techniques would serve you better than the relatively short...