Adam Li

Results 473 comments of Adam Li
trafficstars

Ah I see. Yeah that makes sense to add. I'm in favor.

> @adam2392 can you comment in to clarify what you expect fpath to return in different situations? It will be the basis of an improved docstring > > and sorry...

^ I'm in favor of that. - simplify fpath/str - perhaps a function to try to "infer" raw dataset path (similar to match, but only tries to get the raw...

Should we then: 1. change error to warning 2. error only when BIDS version in mne-bids is less than what's already in `dataset_description` 3. error only when BIDS version in...

> hummm ... interesting > > out of curiosity how long does it take for you to write with and without joblibs? how many subjects do you have? Well rn...

Another issue I just ran into with regards to BIDSPath trying to infer the full path is when extension is specified, but suffix is not. There is no error and...

> This is something that has been on our "want-to-have" list for a while now, so: yes, I want to have this ;) I will need to think about which...

How should we start implementing this? Some ideas that have popped into my head over the months have been: #### For writing derivatives - overload `write_raw_bids` even further, adding some...

@jjerphan just tried this for `sklearn/tree/tests/test_tree.py` and `sklearn/ensemble/tests/test_forest.py` and I don't think it works because the TreeBuilder has this conversion inside `_check_input`, which always forces the X input dtype ```...

Kay I got the CI passing. I think this is ready for discussion @dschult . Lmk if perhaps a call would be easier.