Adam Li

Hi @dschult just wanted to follow up to see if we could converse on some of the high level design choices made here and if they're in line w/ what...

Sure completely understand! Re subclassing Graph: The issue I have there is how to handle the factory methods. My understanding is with #5850 we are at least improving this pattern....

Chiming in here just cuz this feature would be great to add. It's also a metadata column in `channels.tsv` for iEEG-BIDS, so we could add it into downstream `mne-bids`. https://bids-specification.readthedocs.io/en/stable/04-modality-specific-files/04-intracranial-electroencephalography.html#channels-description-_channelstsv

Jw would this feature allow also tagging the "anatomical location" of the IEEG electrodes too?

My only objection with pyedflib writing is that the end file never opened for me in EDFBrowser, which is my primary reason for working in EDF format. My export costs...

Do you have a code snippet I can try?

> * [ ] Annotations will be lost on save. Putting up PR in #10019 > * [ ] It is not yet possible to add annotations to the Epochs...

> From #9969, @adam2392 we should take care of these before 1.0. Creating this issue so that we don't forget: > > * [ ] Annotations will be lost on...

@mmagnuski Thanks glad you find it useful! I'm not sure I follow. Would you be able to illustrate an example for that use case? I think @drammock @larsoner or @agramfort...

I see that makes sense. Then `set_annotations_by_epoch` would set one "annotation" with the duration of the epoch by default. Alternatively, it can set multiple annotations with no duration. I am...