Adam Li

Results 468 comments of Adam Li
trafficstars

My naive guess would be whoever implemented it saw the log and needed to ensure the log was not of a negative number. I'm surprised it was never an issue...

Hey @tingshanL okay thanks! I think this will require a discussion among some of the more senior maintainers on the team. Personally, I do see the use of a mclust...

No ONNX is not supported yet, but the package supports pickling in the same way scikit-learn does. I'm not familiar with how to get ONNX support working. Are there any...

Just to understand a bit better, what is your use-case for using ONNX instead of the actual pickled model? Would you be interested in exploring how to get treeple models...

> @adam2392 Can you help me recheck with Multiview Oblique splitter when uniform sampling condition is true. I modified it to be more reasonable to achieve uniform sampling. Did a...

I'm unsure why the docs are broken, but it would be nice to be able to check the output visually here: https://output.circle-artifacts.com/output/job/96dcd4fa-4fbc-4b29-b358-314687b9af0b/artifacts/0/dev/use.html via the circleCI job: https://circleci.com/gh/neurodata/treeple/561. It makes reviewing...

Hi @weioren note this will not enable splitting on missing values, as the core logic within Cython needs to get implemented.