Adam Li

This is using avoides implementation?

I'm inclined to believe there are issues here simply based off of the simulation that @avoide proposes. It seems weird to me that the `spectral_connectivity_time` does not work for such...

> Thanks @adam2392, I'll try to reproduce @Avoide results tomorrow. Hi @EtienneCmb any luck on this?

Sorry I've been swamped, so lost track of this. Is there a summary then of the bug that needs to be fixed? Is @Avoide 's implementation correct, or the Frites...

Hi, all thanks to @ruuskas contributions in https://github.com/mne-tools/mne-connectivity/pull/104, I think the underlying bug/incongruiences that were discovered in this and related issues have been resolved. @Div12345 not sure if you're still...

@Div12345 this looks good to me because it's a time-resolved measure. Pactools looks like it hasn't been updated since 2020. I think PAC implementation and an accompanying example would be...

I would lean towards integrating it here instead of as a dependency since pac tools isn't maintained.

> Implementing a simple PAC metric as in [[Penny et al 2008]](https://www.sciencedirect.com/science/article/pii/S0165027008003816) or [[Tort et al 2010]](https://journals.physiology.org/doi/full/10.1152/jn.00106.2010) should be straightforward. However, most PAC metrics suffer from the same issue, which...

@dcxSt Feel free to open a PR for this if still of interest

> I agree that using only the l2_reg argument will make things much simpler. Do you want me to implement this and then commit the changes? That would be great...