Alex Potsides

Results 544 comments of Alex Potsides

Perf seems fine - the benchmark added by https://github.com/ipfs/helia/pull/633 shows comparable performance between this branch and main.

Unless I'm missing something, looking at the responses from http delegated routers for [get provs](https://specs.ipfs.tech/routing/http-routing-v1/#get-routing-v1-providers-cid), this check might be something we need to do? The [peer schema](https://specs.ipfs.tech/routing/http-routing-v1/#peer-schema) for providers includes...

We did not make a decision as such, but we did talk a bit about the constraints. 1. Turns out the absence of `transport-ipfs-gateway-http` is [not enough](https://github.com/ipfs/helia/pull/459#discussion_r1509409900) to use as...

> Do you agree with the broad strokes of this approach? Yes, sounds good.

I haven't run this test but from what I can see this passes because `getFirstEntry` breaks out of the `await for..of` which ends the generator and causes the lock to...

Again, I haven't run it but awaiting gc before `getFirstEntry` is called might do the same thing: ```js const retrieved = await storage.getMany(cidsGenerator()) await helia.gc() // might cause deadlock? const...

I'm going to close this because there's been no movement in almost a year. I think yes, if you mis-use async generators you can get yourself into trouble but this...

LGTM but do we want to do this everywhere via https://github.com/ipfs/github-mgmt ?

The WebTransport throttling issue manifests itself as the WebTransport session erroring immediately after it's created. This means we try to dial a peer and fail, moving on to the next...

`@helia/delegated-routing-v1-http-api-client` supports the libp2p routing interfaces too, but it doesn't include the protocols supported by the providers, so it increases the chances of wasted dials, either trying to run identify...