Alex Potsides

Results 542 comments of Alex Potsides

I'm not sure introducing typescript into the spec is a good idea? We already have prose and protobuf as definition languages, adding a third just increases the probability of contradictions...

Very excited for #2657! 👏 👏 👏

Testing minor versions of js-libp2p doesn't give us much since it's the transport/protocol modules doing all the heavy lifting here and those follow their own release schedule separate from js-libp2p....

> Then I suggest increasing it in js-libp2p The point of this PR is so that all implementations use the same chunk size so there is a better basis for...

I think the caching strategy was implemented as-is because building the artefacts required to run the tests was previously very slow - if memory serves it was over 25 minutes...

Looks like fetch may be coming to node after all: https://github.com/nodejs/node/pull/41749

`node-fetch` is a peer dependency of `native-fetch` - this module has a [dependency on `[email protected]`](https://github.com/ipfs/js-ipfs-utils/blob/master/package.json#L159) which is CJS so you should not need to install it yourself. If you are...

This sounds like it should be a PR to is-electron - have you opened an issue there?

Thanks for following up. I think it'd still be a good idea to expand the feature detection as suggested and issues with Jest do come up from time to time.

I think the pinning benchmarks should be re-run with this PR before merging. The `multiformats/block` `.links()` function works by deserializing a block into an object, then recursively walking every property...