Vincent Langlet

Friendly ping @zonuexe I don't want to put pressure on you. It's just not clear to me whether you stopped working on it or not. What is missing ? It...

I'm interested by this PR ; do you have time to finish it @kubawerlos ? (Does it require more than a rebase ?)

> I ran this over a code base that's still using php-parser 4. There's a problem with `usePHPParserV4`, which I've commented on, but with that fixed it seems to work....

I think this i ready to be review @orklah @weirdan

Friendly ping @weirdan if you have time to take a look (or can ping another maintainer ?). This PR would be really helpful, by allowing to use both Psalm and...

Hi, This was implemented here https://github.com/VincentLanglet/Twig-CS-Fixer/blob/0ab7a8154f7b3a6a42cbe3a467074a47bc32dcf5/src/Rules/Whitespace/IndentRule.php#L69-L71 The issue is that when I see 1, 2 or 3 spaces in a file you use tabs and consider 1 tab = 4...

> I've tested similar code with a JavaScript linter that also does formatting (ESLint, Biome) and it works. Maybe we can investigate to see how they handled this case ?...

> * Same problem might happen with pure-callable Currently Closure and callable behave differently https://phpstan.org/r/046d9ead-3b86-4c2a-8d22-c5cd8dec3cf8 This is because of the toPhpDocNode implementation: - callable: https://github.com/phpstan/phpstan-src/blob/ac6dae9b014720d077a4fa371d34ea57e2713cfe/src/Type/CallableType.php#L689 - Closure: https://github.com/phpstan/phpstan-src/blob/ac6dae9b014720d077a4fa371d34ea57e2713cfe/src/Type/ClosureType.php#L805 (we only...

> If we manage to just change the message in the scenario where the types on both sides are the same, then it's a bugfix and we don't need it...

> [@VincentLanglet](https://github.com/VincentLanglet) I don't like that it would change messages to "pure-callable" in a lot of cases imho. I think you mean `pure-Closure`. Cause today, there is already `pure-callable` everywhere....