Vincent Langlet

Results 794 comments of Vincent Langlet

> if you are not sure, you could add a NodeScopeResolverTest to verify your assumption I'm pretty sure it won't close the PHP 8 part (and only fix the issue...

I encounter some issues/questions for you @ondrejmirtes. First, `HasPropertyType` is tricky - since it's used for both static and non static properties. - and `property_exists` returns true either it's a...

In the new list of todo to see with you @ondrejmirtes I have: - `PHPClassReflectionExtension::createProperty` to maybe split into createInstanceProperty and createStaticProperty (?) ; I'm not familiar with the implementation...

Rebased and fix, it should be ready for a new review @ondrejmirtes :)

It's rebased and fixed I think. I know it's not an easy PR to review @ondrejmirtes but it would be awesome if we succeed closing it :) Is there something...

It's rebased and fixed again. This PR is really hard to maintain, are you (still ?) interested in it @ondrejmirtes ? Can I do something to help you to review...

Rebased and I had to introduce new fixes because of recent bugfixes. Should be re-ready for review @ondrejmirtes

> nit: PR description contains a wrong link Thanks, updated to https://github.com/phpstan/phpstan/issues/12775

> bisected this new errors to [phpstan/phpstan-src#3788](https://github.com/phpstan/phpstan-src/pull/3788) > > //cc [@VincentLanglet](https://github.com/VincentLanglet) I don't consider this to be a `is_a` regression since I can reproduce this bug differently like https://phpstan.org/r/73b2d6e1-9661-4375-b01d-cdd6ec39c69e This...