Vincent Langlet

Results 794 comments of Vincent Langlet

> I'm not opposed to normalizing them. Primarily we need to ensure any changes cause as little pain as possible. Changing the casing shouldn't break any existing code, but might...

This is a nice suggestion @okorneliuk, I tried https://github.com/lexik/LexikJWTAuthenticationBundle/pull/1278

> We encountered the following issue - after the execution of composer update, some of our migrations stopped working correctly. HI @ko4aisheretodev. Do you have an example of the code...

> Also see that SET foreign_key_checks = 1 is not executed, but from your response, I understand that this is expected behavior (though it might not be obvious). I agree...

Maybe something like this https://github.com/doctrine/migrations/compare/3.8.x...VincentLanglet:migrations:warning-instead @derrabus @greg0ire WDYT ? And then the `DoctrineMigrationBundle` would add a `addMethodCall` in the DependencyFactory definition (?)

> I recently faced this exception. In case it's useful for folks reading this, the following change fixed it: > > ```diff > public function postUp(Schema $schema): void > {...

No, see https://onlinephp.io/c/e8c00

I think this can be closed @ondrejmirtes since the error reported in https://phpstan.org/r/97ccd5aa-cde7-40a1-b58e-e004b4d03159 is valid https://onlinephp.io/c/e8c00 and explained by https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static

> @VincentLanglet > > i think putting both annotations on top of a class works, e.g. > > ``` > #[When(env: 'prod')] > #[AsCronTask(...)] > class Foo > ``` This...