Vincent Langlet

Results 795 comments of Vincent Langlet

> Ping @RobinDev @VincentLanglet - Do you want me to do a MR on this to avoid introducing a BC break ? Sure !

> @VincentLanglet et al -- please consider this for a `1.19.0` release. It retains dbal 3 compatibility so no major version upgrade should be needed. Sure, but tests should be...

Do you prefer that I target 2.1.x @ondrejmirtes ?

> Anyway, can be done in a follow-up too IMO, so this comment should not be considered a blocker IMO 😊 and I can volunteer to do this. Yeah, I...

Tests failure seems unrelated since I modify only phpdoc

I think the issue can be simplified to https://phpstan.org/r/c5b09520-fa4d-4e0a-b350-6df4a39042b2 Seems to be worst with defined keys https://phpstan.org/r/9dd5b693-9460-48e1-a64f-cc63725aaa9f

Changing this to a benevolentUnion has some drawbacks. For instance https://phpstan.org/r/26a42e39-70af-4381-a912-f323206ce172, (when you imagine that `2 / $number` will be replaced by `$number + 1`). 99,99% of the int used...

> It should be fine if it stays benevolent, but looks like in your example it gets lost :/ I was surprised too, because I thought PHPStan was changing `(A|B)|C`...

> I am not sure if this is wanted as it is not much feasible. A partial regex string is impossible to be validated as the delimiter is unknown. Shouldn't...