Viktor Hofer
Viktor Hofer
https://github.com/dotnet/arcade/blob/b5c8d9f6ae7c14af9e5e162e55201d41ebc191f5/eng/common/tools.ps1#L4-L52 All the `bool` switch conditions are always true even if the switch isn't supplied to the eng/common/build.ps1 file. Example: `if (Test-Path variable:binaryLog)` is always true as `binaryLog` is defined...
Fixes https://github.com/dotnet/arcade/issues/15724 Fixes https://github.com/dotnet/dotnet/issues/1017 ### To double check: * [ ] The right tests are in and the right validation has happened. Guidance: https://github.com/dotnet/arcade/blob/main/Documentation/Validation.md
https://github.com/dotnet/arcade/blob/490307dc9bb09caf016b2fa96005ac8aaa89c4e7/src/Microsoft.DotNet.Arcade.Sdk/tools/ProjectDefaults.props#L32-L33 Windows PDBs were originally produced to support tools like WinDbg and Watson. From what I see, both of these tools already support portable PDBs. I.e.: https://github.com/MicrosoftDocs/windows-driver-docs/blob/staging/windows-driver-docs-pr/debugger/symbols-portable-pdb.md#portable-pdb-symbols Roslyn, razor and...
ConditionalClass and similar attributes add a `failing` trait to the tests that should conditionally not run: https://github.com/dotnet/arcade/blob/1ccd352f12e845d89e5b5a9b800e2be88f8a6d98/src/Microsoft.DotNet.XUnitExtensions/src/Discoverers/ConditionalClassDiscoverer.cs#L30 It might make sense to automatically filter those out without relying on the...
Today, a VMR build publishes non-shipping packages to the `dotnet10-transport` feed and shipping packages to the `dotnet10` feed. This includes i.e. Arcade packages which users expect to go into `dotnet-eng`,...
Edit by carlossanlop: - I marked it as "BuildRetry" as it is failing intermittently. - I don't know who the rightful owner is, if Area-CLI or Area-Templates, so I added...
CoreFx doesn't use the Microsoft.NETCore.App.Ref targeting pack as we build the refs ourselves. Without that targeting pack the `ResolvePackageFileConflicts` task seems to not be able to handle conflicts between package...
This package recently got broken and will be fixed with https://github.com/dotnet/templating/pull/8952/. This highlighted that there aren't any integration tests running for that package. As this is an msbuild tasks package...