Viktor Hofer

Results 78 issues of Viktor Hofer

### Background and motivation When referencing the FluentAssertions nuget package a five years old version of the System.Configuration.ConfigurationManager package gets referenced transitively. Those ancient 4.x.x versions of "System" nuget packages...

api-approved
triage

... when building from source. This was the only remaining project in roslyn that brought them in. Contributes to https://github.com/dotnet/source-build/issues/4482

Area-Interactive
Community
untriaged

When doing `build.sh --pack` to generate nuget packages in addition to building the repository, at least one nuspec fails to build. > /vmr/.dotnet/sdk/9.0.100-preview.2.24103.2/Sdks/NuGet.Build.Tasks.Pack/buildCrossTargeting/NuGet.Build.Tasks.Pack.targets(221,5): error NU5019: File not found: 'netcoreapp3.1\testhost.exe'. [/vmr/src/vstest/src/package/Microsoft.TestPlatform.TestHost/Microsoft.TestPlatform.TestHost.csproj]...

https://github.com/dotnet/arcade/commit/9a643b7b15a044f249a1d569c1c170b88245a47c had some issues that weren't caught in CI in arcade or arcade-validation. We should add validation so that issues will be identified before promoting bits to the `.NET Eng...

untriaged

With https://github.com/dotnet/corefx/pull/36560 we added a target which restore internal tools locally. This is needed for tools like TestILC. We download/install the nuget credentials provider and invoke dotnet restore --interactive on...

> /vmr/.dotnet/sdk/9.0.100-preview.7.24325.1/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(187,5): error NETSDK1215: Targeting .NET Standard prior to 2.0 is no longer recommended. See https://aka.ms/dotnet/dotnet-standard-guidance for more details. [/vmr/src/source-build-reference-packages/src/referencePackages/src/humanizer.core/2.2.0/Humanizer.Core.2.2.0.csproj::TargetFramework=netstandard1.0] `$(NoWarn);NETSDK1215` doesn't work. I see there's a separate msbuild property...

untriaged
Area-NetSDK

A few projects set `annotations` as resolving nullable reference type errors requires some work. This issue tracks doing that work and removing the annotations setting.

The [`_GetProjectReferenceTargetFrameworkProperties` target](https://github.com/dotnet/msbuild/blob/a6f6699d1f70bf79db82030938d2c5e52d1e4d2e/src/Tasks/Microsoft.Common.CurrentVersion.targets#L1706) is responsible for annotating ProjectReference items with various metadata (`SetTargetFramework`, `UndefineProperties`, ...). When specifying multiple `ProjectReference` items with the same identity, the metadata isn't applied which results...

triaged
gathering-feedback

## Description Fixes # (issue, if applicable) ## Checklist - [ ] Test cases added - [ ] Performance benchmarks added in case of performance changes - [ ] Release...

NuGet Audit docs: https://devblogs.microsoft.com/nuget/nugetaudit-2-0-elevating-security-and-trust-in-package-management/ & https://learn.microsoft.com/en-us/nuget/concepts/auditing-packages NuGet Audit flags vulnerable dependencies at restore and build time so that we don’t have to exclusively rely on post-build scanners like Component Governance....