James Turner

Results 197 comments of James Turner
trafficstars

It is _technically_ behaving as intended though the intended behaviour isn't fantastic. Basically the `ValueJsonConverter` performs a "right-to-left" type check for any objects it tries to deserialize. The types for...

Looks like our issue is this block of code in S.T.J: https://source.dot.net/#System.Text.Json/System/Text/Json/Serialization/Metadata/JsonPropertyInfoOfT.cs,353 There are a couple of flags around there that we might be able to toggle to get this...

I should mention - that the block of code I linked to is likely based on the master/main code in the Runtime, not necessarily what we are using. ~We don't...

Setting `HandleNull` does make our converter run however another internal part of S.T.J trips: ![image](https://user-images.githubusercontent.com/904226/153318227-8dba023b-cef9-449c-bb6f-973aff95da05.png) I'm thinking that S.T.J is doing this because a struct can't technically be null instead...

Tried to mess around with a few settings but doesn't seem like there is anything we can do without trying something drastic like switching `Values` and `OneOrMany` to be reference...

While it would be cool, I don't have the capacity to do this in the short term. I think we get a release out with S.T.J now and plan out...

My thought was something like: ```csharp public struct SchemaDate { #if NET_6_OR_GREATER private DateOnly BackingDate; public static implicit operator DateOnly(SchemaDate schemaDate) { /* ... */ } public static implicit operator...

Here are my quick thoughts for the scope of what I think would need changing/issues you might hit... I think these places at minimum would need changing: - Source generator...

Yeah, the referenced PR is merged and the library supports deserialization. Depending on what version you're using of ASP.NET, it could be using Newtonsoft.Json or System.Text.Json - currently the library...

Interesting - you thinking have this on `Thing` or maybe each of our derived types implements it? Should mostly be able to pass it off to the `SchemaSerializer` class.