James Turner

Results 197 comments of James Turner

Hey @RobSchoenaker - thanks for the link however Quickenshtein already uses that optimization and a bunch more. If you're curious about some of the exotic optimizations, you can check out...

No problem mate! Hopefully you find some of the links I've given interesting.

While maybe not as accurate as `perf` on Linux, it is possible to achieve this with ETW on Windows and the support for Hardware Counters in BDN. See: https://adamsitnik.com/Hardware-Counters-Diagnoser/ ```csharp...

Can't land the "Worthiness" or "Code Size" columns until a new version of BDN comes out with them (something after v0.12.0) as the `DisassemblyDiagnoser` of the current versions doesn't add...

Not sure what is going on there - maybe an issue with the encoding/unicode but at the same time, I kinda doubt it as I'd imagine the core runtime is...

That is _currently_ intentional with what we are doing here: https://github.com/RehanSaeed/Schema.NET/blob/main/Source/Common/SchemaSerializer.cs#L79-L90 To be honest, I don't remember exactly why we do this but I'm not personally opposed to changing it...

While it probably works well enough for the example of "Product" and "Car", this would have some really weird issues when it comes to types that don't inherit from each...

There is also [an adjacent issue](https://github.com/RehanSaeed/Schema.NET/issues/419#issuecomment-1073004550) to this due to how we handle deserialization to a `Values` type. We attempt to deserialize by the order of the types from right-to-left...

> I imagine the `@type` being a OneOrMany, that change would have to be applied everywhere... Yeah, that's what it would need to be to make part of the serialization/deserialization...

There may have been an issue where pending properties (in some cases) were included but not pending types (or properties that depended on those types). That would have been a...