Thomas Landauer
Thomas Landauer
See also https://github.com/Codeception/module-symfony/issues/22#issuecomment-715251498 for some thoughts.
Well, thanks, but `reloadPage()` is not available in functional tests, only in acceptance tests :-(
Same for `checkOption()`/`uncheckOption()` with a `.checkbox-custom` checkbox
`lib-innerbrowser` has just [`seeInSource()`](https://github.com/Codeception/lib-innerbrowser/blob/master/src/Codeception/Lib/InnerBrowser.php#L557) - so this is probably the way to go.
In short: I don't agree ;-) In long: Codeception is a testing framework, not a best-practice guide. So besides the fact that for *any* best-practice there will always be some...
Actually, "delete" isn't really the right term here. I'd say: Either **unsetHttpHeader()**, or (to be consistent with `have...`) **dontHaveHttpHeader()**
If you merge this, I'll do the same in lib-innerbrowser.
Both functions also exist in lib-innerbrowser: * https://github.com/Codeception/lib-innerbrowser/blob/master/src/Codeception/Lib/InnerBrowser.php#L2061 * https://github.com/Codeception/lib-innerbrowser/blob/master/src/Codeception/Lib/InnerBrowser.php#L2047
`QueryBuilder::orderBy() / addOrderBy()` was the place where I initially suggested to get rid of those strings (https://github.com/doctrine/orm/pull/11263) - so this is a must IMO :-)
Anybody who was using `->orderBy('foo', Criteria::ASC)` is kinda stuck now (after upgrading to `doctrine/collections` 2.2.0). PHPStan is going crazy with: > Fetching deprecated class constant ASC of class Doctrine\Common\Collections\Criteria: use...