module-rest icon indicating copy to clipboard operation
module-rest copied to clipboard

Published 20 hours ago • verified publisher icon Codeception

Rename `deleteHeader()` to `unsetHttpHeader()`

Open ThomasLandauer opened this issue 5 years ago • 3 comments

To be consistent with all other header functions: haveHttpHeader() (to which it is the counterpart), seeHttpHeader(), seeHttpHeaderOnce(), etc.

Also in lib-innerbrowser

ThomasLandauer avatar Oct 03 '20 20:10 ThomasLandauer

Actually, "delete" isn't really the right term here. I'd say: Either unsetHttpHeader(), or (to be consistent with have...) dontHaveHttpHeader()

ThomasLandauer avatar Oct 03 '20 21:10 ThomasLandauer

A PR to fix this could be implemented without breaking BC. Just add an alias for the "wrong" function name and mark it deprecated. Move the implementation to the "right" function name.

SamMousa avatar Oct 14 '20 15:10 SamMousa

If you merge this, I'll do the same in lib-innerbrowser.

ThomasLandauer avatar Oct 14 '20 18:10 ThomasLandauer