Thomas Landauer
Thomas Landauer
I read the RFC (see https://github.com/zbateson/mail-mime-parser/issues/133#issue-675312518) as if you use non-ASCII characters you *must* declare a charset in the `Content-Type` header. Right?
First: I'm not sure if `->setCharsetOverride()` is actually doing what you had in mind. I'm understanding https://github.com/zbateson/mail-mime-parser/issues/133#issuecomment-670775985 that it would only set a *default* charset (i.e. only makes a difference...
> and use `setCharsetOverride` if it isn't, thereby setting your own default charset using that. Well, if I override the existing charset, it's not "default" anymore! Default means: If there...
I can now report from the emails I'm analyzing: Before, **0.36%** had text in UTF-8, but without a `charset` declaration (and were therefore displayed wrong). With the code from https://github.com/zbateson/mail-mime-parser/issues/136#issuecomment-680022755...
> Perhaps AddressHeader::getDisplayValue or something? No, sorry, I didn't point that out clear enough: This is a *general* header issue, not just about `From`! So if the email contains: ```...
Just noticed that [RFC 5322](https://tools.ietf.org/html/rfc5322#section-2.2) uses the term "body" for what I called "content": > Header fields are lines beginning with a field name, followed by a colon (":"), followed...
> But isn't there? __toString, getRawValue, getValue No, since for a `To` header, `getValue()` only returns (a) the *first* address, and (b) just the email part of that. This behavior...
Yeah, sure the second is shorter - but how can you know in advance that the address you're looking for must be the first one?
> In your example though, Subject, getValue would give result 3. Yeah, sorry, I missed that cause I was misled by the "errors" caused by https://github.com/zbateson/mail-mime-parser/issues/130 > I think you'd...
Well, I for myself don't care how you handle the transition :-) Semantic versioning probably demands the deprecation since it's a BC break. BTW: How could you "send" a deprecation...