Adrian

Results 567 comments of Adrian
trafficstars

I think the placement of the button is nice, but it looks really bad when there are no documents yet in a registration: ![image](https://github.com/indico/indico/assets/179599/d8fe62ae-1cb1-4b78-9c1c-cfd4386bdc3b) I suggest keeping the box title...

![image](https://github.com/indico/indico/assets/179599/00d2a219-62f4-4c0f-b5af-33f77ea0f2ac) ![image](https://github.com/indico/indico/assets/179599/90bdf505-a23e-4621-8c26-01043fd66473) - The title should stay the same - There shouldn't be two titles in case of existing documents - The message I proposed should be in the "body"...

> It would be nice to make the shown social providers configurable (per site would be ok) If any API credentials etc were needed I'd agree, but since that's not...

Wouldn't it make sense to use a token instead of allowing access by just knowing the (easy to enumerate) URL, similar like we do for private surveys?

What I mean is that it'd just affect the link you send - it's still be the same link for everyone. So I think for your usecase it would work...

How about `form_token`? In principle UUIDs are unique enough to share the same query arg - so you could also first check if it's a valid registration token and otherwise...

"To register, use link" isn't correct English. My suggestion would be to show it nicely as a box in the registration management dashboard, similar to what we do for surveys....

@vtran99 I fixed a few issues and as far as I'm concerned it's good to be merged now. Feel free to have a last look as well.

@foxbunny I rebased this PR to the latest master and applied a few minor fixes for very straightforward things I encountered while testing. I think finishing this PR could actually...

FYI I've forcepushed a rebased version of this PR since I fixed an unrelated bug in the room booking form earlier today