Adrian

Results 569 comments of Adrian
trafficstars

No need to squash since you do not have merge commits int here :) We'll squash+merge at the end anyway (same like in the google wallet PR and most other...

This is just Apple being Apple. The fact that those passbook files even NEED to be signed is kind of ridiculous. And we want to have this configurable by category,...

![image](https://github.com/indico/indico/assets/179599/d15cb0a6-e04d-4227-9b42-807b848a7887) We need to come up with something better here...

I'm done with my tests/reviews/fixes. Once the display issue from my previous comment is fixed I'm ready to merge it.

Fine for me. Just wondering, should we reverse the text there? - regform (PDF) - regform (Google Wallet) - regform (Apple Wallet / Passbook) I think it'll be more readable...

How about just calling it "Add to [mobile?] wallet" and then show the Google Wallet / Apple Wallet options int her dropdown? The current text sounds way too verbose, and...

I think we agreed some time ago to call it "Apple Wallet" but, in this particular place, to also mention "Passbook" since that's a term Android users with an app...

Seems fine, I think we can ditch the icons in the dropdown though? And maybe put it after "Get ticket"? That way it's clearer that "Add to wallet" references the...

Yes, looks fine, it was just the focus borders in your screnshot.

yep that'd look nicer for sure